Skip to content

Add support for architecturecraft block state printing - #27

Open
Wozard wants to merge 5 commits into
GTNewHorizons:masterfrom
Wozard:feat/architecturecraft_support
Open

Wozard wants to merge 5 commits into
GTNewHorizons:masterfrom
Wozard:feat/architecturecraft_support

Conversation

@Wozard

@Wozard Wozard commented Mar 26, 2026 •

Copy link
Copy Markdown

Adds the ability to differentiate between different Architecturecraft block cuts, and orient them correctly during printing.

Depends on a separate update to Architecturecraft, which adds a SetOrientation message for Schematica to use after placing the Architecturecraft block, in order to correct its orientation. The PR for the Architecturecraft update is here: GTNewHorizons/ArchitectureCraft#35

Before/After:
image

@Wozard
Wozard requested a review from Sanduhr32 April 1, 2026 17:50

@Sanduhr32 Sanduhr32 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't wanna be the guy giving the green light, but it looks better than the initial state of the PR. Have you tested your changes?

@RecursivePineapple RecursivePineapple left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, one minor nitpick. The only blocker is the issue in the other PR.

Comment on lines +256 to +261
if (ArchitectureCraftHelper.isLoaded() && ArchitectureCraftHelper.isShapeBlock(
schematicFlipped.getBlock(tileEntity.xCoord, tileEntity.yCoord, tileEntity.zCoord))) {
byte[] ori = ArchitectureCraftHelper.getOrientationFromTE(tileEntity);
byte[] newOri = ArchitectureCraftHelper.transformOrientationFlip(ori[0], ori[1], direction);
ArchitectureCraftHelper.setOrientationOnTE(tileEntity, newOri[0], newOri[1]);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these AC code blocks look identical, can we pull them out into a single method?

@Sanduhr32

Copy link
Copy Markdown

@RecursivePineapple do you want me to hijack this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants